sigs,generate: update sig-list generation for wgs #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
dco-signoff: yes
This was referenced Nov 5, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jean-edouard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
8 tasks
dhiller
force-pushed
the
add-wg-sig-list-generation
branch
from
efe7e38 to
493f030
Compare
dhiller
commented
Nov 7, 2024
| @@ -19,7 +19,7 @@ | |||
| */ | |||
| -}} | |||
| {{- /* gotype: kubevirt.io/community/generators/cmd/sigs.SigListTemplateData */ -}} | |||
| {{ define "group" }}|[{{ .Name }}]({{ .Dir }}/charter.md) |[{{ .Label }}](https://github.com/kubevirt/kubevirt/labels/{{ .Label }})|{{ if .Leadership }}<ol>{{ range $index2, $chair := .Leadership.Chairs }}<li>[{{ $chair.Name }}](https://github.com/{{ $chair.Github }}), {{ $chair.Company }}</li>{{ end }}</ol>{{ end }} |{{ if .Contact }}[Slack]({{ .Contact.Slack}})<br/> [Mailing List]({{ .Contact.MailingList }}){{ end }} |<ul>{{ range $index3, $meeting := .Meetings }}<li>{{ $meeting.Description }}: [ {{ $meeting.Day }} at {{ $meeting.Time }} {{ $meeting.TZ }} ({{ $meeting.Frequency }}) ]({{ $meeting.URL }})</li>{{ end }}</ul> |{{ end }} | |||
There was a problem hiding this comment.
@jean-edouard so this is the change in the template that I promised, hope it's ok for you to do this here - since we are changing the template anyhow I think that's fair.
Adds generation of section for working groups to sig-list.md . Signed-off-by: Daniel Hiller <[email protected]>
This commit also adds the changes wrt non existing labels, therefore there's empty rows in case no label is present. Signed-off-by: Daniel Hiller <[email protected]>
dhiller
force-pushed
the
add-wg-sig-list-generation
branch
from
493f030 to
080dbaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds generation of section for working groups to
sig-list.md. This is required now since we got our first working groups around architectures with #298.In a separate commit the changes for the latest WG additions are applied.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Note: this is a manual cherry-pick from the original changes in wg-code-quality PR #333
/cc @aburdenthehand @lyarwood